Fix router tests #139
Merged
Fix router tests #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-mainnet into fix/router-tests
…t into fix/router-tests
Regarding memory leak. In the `Write` method of the route group we call `writePacketAsync`. It returns `errCh` to us to wait the error from, this channel is not buffered, so `writePacketAsync`'s goroutine actually blocks while trying to pass error to this channel. But `Write` blocks on `select` waiting either error from `errCh` or error from write deadline struct. And if it gets deadline error, it just returns without waiting for any error from `errCh`, making `writePacketAsync` block forever on sending to the channel. And we might have had a lot of such running goroutines
|
Just one more subtest of |
Darkren
requested review from
nkryuchkov,
evanlinjin and
Kifen
and removed request for
nkryuchkov
evanlinjin
approved these changes
Feb 1, 2020
| require.True(t, rg0.isClosed()) | ||
| require.True(t, rg1.isRemoteClosed()) | ||
| require.True(t, rg1.isClosed()) | ||
| require.True(t, rg2.isRemoteClosed()) | ||
| // rg1 should be done (not getting any new data, returning `io.EOF` on further reads) | ||
| // but not closed |
There was a problem hiding this comment.
Should be specify:
// rg1 should be closed for reads (returning `io.EOF` on further reads), but not on writes.Is this the intended behaviour?
There was a problem hiding this comment.
@evanlinjin yep. io.EOF is only returned when the connection is broken (we test this via isRemoteClosed) and no data left on the wire (we check the readCh for it). this was the only way to make route group behave like the usual connection, and also it seems like the most correct one to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102
Changes:
TestArbitrarySizeOneMessageTestArbitrarySizeMultipleMessagesByChunkstestPresentTimeoutsubtest ofTestConntestCloseTimeoutsubtest ofTestConn